fix: recover bump files for release notes and fix git tag push auth#73
Merged
Conversation
- Recover deleted bump files from version commit (HEAD~1) so GitHub release bodies are populated with changelog content in the post-merge publish flow - Fix git tag push failure: switch from URL-embedded token to http.extraheader (same mechanism as actions/checkout), which takes priority over credential managers on CI runners - Remove redundant `git push` before `git push --tags` in pushWithTags — in the publish flow there are no new commits to push - Add extractChangelogEntry helper to extract changelog entries from CHANGELOG.md
|
The changes in this PR will be included in the next version bump.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
withGitTokenwas embedding the token in the remote URL (x-access-token:TOKEN@github.com/...), but newer git credential managers on CI runners intercept the connection and ignore URL-embedded credentials, causinggit push --tagsto fail with "could not read Username". Now useshttp.<server>/.extraheader = Authorization: bearer TOKENinstead — the same mechanismactions/checkoutuses, which takes priority over credential managers.git pushinpushWithTags: The commit push beforegit push --tagsis unnecessary in the publish flow (no new commits to push) and was the command that was actually failing first.ciReleaseCommandnow recovers them from the version commit (git diff HEAD~1 HEAD --diff-filter=D) and passes them topublishCommand, so GitHub release bodies are populated with proper changelog content.extractChangelogEntryhelper: Extracts a specific version's entry from a CHANGELOG.md string (for use in release body generation).Test plan
recoverDeletedBumpFilescorrectly reads bump file content fromHEAD~1